search

Wohlstand / OPL3BankEditor

A small cross-platform editor of the OPL3 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
141 stars 12 forks source link

Unable to save percussion banks to IBK files #205

Open SenhorFlibble opened 10 months ago

SenhorFlibble commented 10 months ago

I've run into further issues with IBK file conversion. It appears that unlike other bank file types, IBK files do not have separate banks for melodic and percussion instruments, instead this is determined on a per-instrument basis within a single list (at least, this is how it seems to work, judging by the editing options in SBTimbre).

When I create a new bank file in OPL3BankEditor and import percussion instruments from a GENMIDI.op2 bank to the percussion part of the new file and save it as an IBK, it turns out simply empty when I open it in SBTimbre. The only workaround I've come up with so far is to import percussion instruments into the melodic bank and save it as IBK that way, then manually change each instrument to percussion in SBTimbre. Any way to get around this?

Wohlstand commented 10 months ago

I guess, it's an architectural mistake, because I attempted to repeat the logic of SBTibre as it doesn't separate banks for "drums"/"melodic" and has each instrument "is drum" marker. Yesterday I had thinks about changing this, but I was too sleepy. Good that you made this issue, so, I'll try to make wrappers to save as ibk separately melodic-only and drums-only. Otherwise, it's a mess.

Wohlstand commented 10 months ago

Also, I forgot to tell the fact, that IBK files do able to save drums as Rhythm-mode only.

SenhorFlibble commented 10 months ago

Thank you for the swift replies! I've just tried a conversion of percussion instruments from DMXOPL v1.11 in MBF (the original Killough release, as @gerwin's modified Allegro library seems to have issues with IBK files), but even though I set every instrument to percussion type, they sound off, whereas the melodic instruments match the sound of DMXOPL's GENMIDI in vanilla Doom quite well. Here are my converted files, both edited in SBTimbre after conversion via the OPL3BankEditor: dmx_ibk.zip