Scrolling trouble when working with non-zero drum bank

Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)

GNU General Public License v3.0

42 stars 8 forks source link

Scrolling trouble when working with non-zero drum bank #34

Closed Wohlstand closed 6 years ago

Wohlstand commented 6 years ago

When choosing non-zero percussion bank, any attempt to choose instrument in the list drops the scroll down after little moment

peek 2018-08-21 01-50

jpcima commented 6 years ago

EDIT I am able to reproduce the issue. Gotta look in more detail.

~~I'm not able to make the problem happen on my side unfortunately. I've opened DMXOPL3-GS for a test and nothing happened.~~

Wohlstand commented 6 years ago

This is not happens in OPL3-BE, happens on OPN2 - BE.

freq-mod commented 6 years ago

It also affects melodic banks as well, steps to replicate:

take YM2612.wopn from https://github.com/papiezak/DMXOPN2
select GS bank no.1, click on any instrument...
...and it should go down to a bottom of the list. What's weird it doesn't affect all banks in my case (for example, my Power Drumkit/GS Bank no. 2 behaves correctly :suspect:

jpcima commented 6 years ago

I've made some traces and don't find myself much more advanced about this issue. It's curious how this problem happens within a delay of clicking on instruments. (and to my knowledge there is nowhere a temporization such as timers)

One thing I found, it's maybe related with having hidden list items in the set. If I comment the setHidden which makes rows invisible on a bank switch, the bug is not happening.

Wohlstand commented 6 years ago

Seems it's a Qt side glitch... ~~so, is need to refactor the ssg-eg combobox to avoid elements are needs to be hidden~~

EDIT: Miss looked. Yeah, it's reasonable to begin replacement with QListView thing where the visibility management is under our control (On side of PGE Editor I have made itembox model where I have made flexible filter search with categories and groups. Originally on ListWidget the thing was a bit glitchy when doing filter search with same hiding of elements. With my model this crap has gone. Seems I need to backport my thing to here and use it... I'll try to do that at evening...

Wohlstand commented 6 years ago

Okay, after some other works (possibly with adding of grayed blank instruments), this bug has been gone!

freq-mod commented 5 years ago

Well, apparently the bug is still here! It still drops down an entire list of patches: bug stillhere