search

Wohlstand / OPN2BankEditor

A small cross-platform editor of the OPN2 FM banks of different formats (Downloads in README below)
GNU General Public License v3.0
40 stars 8 forks source link

Deduplicate operator UI and simplify #80

Closed jpcima closed 4 years ago

jpcima commented 5 years ago

This is an update of UI code to simplify for future development. For now, I have not tried very extensively.

The operator UI, which is done 4 times in the main window, has been deduplicated into 1. At the same time, all the duplicated slot handling was eliminated.

I took a simpler way of doing: read or write a whole operator from the control set. The current way is not too different in logic, it's about equivalent except in smaller code size.

Wohlstand commented 5 years ago

I'll review this soon, loos good idea, I wanted to make same, but was focused on other things...

jpcima commented 4 years ago

Hi, did you have some time to review this patch?

Wohlstand commented 4 years ago

Oh, thanks for reminding, didn't review as I was overtired and often out of my home... Gonna check it...

jpcima commented 4 years ago

Yeah I really wish that I can port it over to OPL3-BE. I've wanted this so I can implement easier copy-pasting betweem the operators.

Wohlstand commented 4 years ago

One thing I forgot - it conflicts with my experimental branch related to PSG and DACs, however, that's fine, that branch partially is crap, and I think, I'll rework it into something different...

Wohlstand commented 4 years ago

Merged this! I also have made a small change to add translationing into operator widgets which was missing... Now everything works! :fox_face:

Wohlstand commented 4 years ago

Okay, bye bye my sketch-psg-and-wt branch, it's now broken, will remake it then, or will try to merge with this... Looks like only 3 files are conflicted, I hope, that shoud be easy to fix...

jpcima commented 4 years ago

Alright good, I will later repeat this work on OPL side. Thanks :+1: