Wohlstand / libOPNMIDI

A Software MIDI Synthesizer library with OPN2 (YM2612) emulator
GNU Lesser General Public License v3.0
96 stars 6 forks source link

Adapt volume models are was designed for OPL3 to OPN2 #44

Closed Wohlstand closed 5 years ago

Wohlstand commented 6 years ago

Volume models feature that used in libOPNMIDI, was imported from libADLMIDI, and has only small change that multiplies formula result into 2. This is not correct, because OPN2 has much stronger logarithmic scale than OPL3 has. It needed to adapt all existing volume models (except of Generic which is fine now, and "Native OPN2" which made with a sense to just map MIDI volume 1:1 to the chip without of conversions) to be correctly sounding on OPN2 chip.

jpcima commented 6 years ago

Maybe it's needed to have volume correction for some real cases. In GYB files was the bank of fmmidi, which is significantly quieter than other banks in the set. This bank comes also as a "volfix" variant, that I recall as sounding as if distorted when used.

freq-mod commented 6 years ago

"CMF" volume model doesn't work properly, it's either silent, extremely quiet or producing short clicks All other volume models sound OK; tested on pge musplay

Wohlstand commented 6 years ago

The "CMF" is legacy name, and it was renamed into "Native OPN2" for OPNMIDI and "Native OPL3" for ADLMIDI, and it's sense to map 1:1 the MIDI range into chip's native range without of conversions.

Wohlstand commented 5 years ago

Okay, as this task is solved long times ago and no activity, close this.