search

Wolfieheart / ArmorStandEditor

Spigot/Paper etc. plugin to allow players to edit armorstands without commands.
GNU General Public License v3.0
25 stars 19 forks source link

[Bug]: infinite loop when starting on 1.21 #546

Open quiquelhappy opened 6 days ago

quiquelhappy commented 6 days ago

Expected behavior

if anything fails loading, the plugin should disable itself

Observed/Actual behavior

the plugin causes an infinite loop, preventing the server from starting up

Steps/models to reproduce

use paper 1.21

Plugin list

not needed

Plugin Version

1.20.6-46.2 hotfix

Server Version

1.21 paper

Other

[10:07:24 INFO]: [ArmorStandEditor] ================================ [10:07:24 INFO]: [ArmorStandEditor] SpigotMC: true [10:07:24 INFO]: [ArmorStandEditor] Enabling ArmorStandEditor v1.20.6-46.2 [10:07:24 WARN]: Enabled plugin with unregistered ConfiguredPluginClassLoader ArmorStandEditor v1.20.6-46.2 [10:07:24 INFO]: [ArmorStandEditor] ======= ArmorStandEditor ======= [10:07:24 INFO]: [ArmorStandEditor] Plugin Version: v1.20.2-44.1 [10:07:24 WARN]: [ArmorStandEditor] Minecraft Version: 1.21 [10:07:24 WARN]: [ArmorStandEditor] ArmorStandEditor is not compatible with this version of Minecraft. Please update to at least version 1.17. Loading failed. [10:07:24 INFO]: [ArmorStandEditor] Disabling ArmorStandEditor v1.20.6-46.2 [10:07:24 INFO]: [ArmorStandEditor] Removing Scoreboards required for Glowing Effects [10:07:24 ERROR]: [ArmorStandEditor] Team Already Appears to be removed. Please do not do this manually! [10:07:24 INFO]: [ArmorStandEditor] ================================

Wolfieheart commented 6 days ago

And you have tried with this build? https://cdn.discordapp.com/attachments/1136566678713552946/1257645511746519120/armorstandeditor-1.21-47.jar

As that is the official 1.21 beta build - Its the same as 1.20.6-46.2 but with 1.21 support directly.

NOTE That build is in BETA. So please be careful with using it in Production. Feel free to also open Issues on that one as well,.

Wolfieheart commented 6 days ago

Also has to do with the check that we have for Versions:

https://github.com/Wolfieheart/ArmorStandEditor/blob/master/src/main/java/io/github/rypofalem/armorstandeditor/ArmorStandEditorPlugin.java#L137

Something I could slightly refactor again if needs be, but explains why 1.20.4-46.2 Hotfix or lower, wont work exactly on Servers. 1.21-47 normally will also have a check in it to allow loading on 1.21