WolfyScript / CustomCrafting

Spigot based plugin to create your own custom Recipes & Items. Designed to be easy to use with in-game GUI and tons of configuration possibilities.
https://modrinth.com/plugin/customcrafting
GNU General Public License v3.0
113 stars 36 forks source link

LoreMergeAdapter / NBTMergeAdapter or NBTMergeExceptAdapter #174

Closed TiaTheFairy closed 1 year ago

TiaTheFairy commented 2 years ago

The Problem

So some other plugins adding custom event/enchantment, etc, via adding a lore on the item, which is not able to be merged by the EnchantmentMergeAdapter.

Also, there is a custom durability system in CustomCrafting's item creator, but players are not able to fix the item through anvil, even by Essential's /fix command.

Solution

For custom event or enchantment implied by other plugins via adding lores, a LoreMergeAdapter would be nice to use.

For custom durability system in CustomCrafting's item creator, maybe a new system, aiming to make it possible to fix the customized durability item is good? Like a command/adapter, etc.

Alternatives

For custom event or enchantment. Well I have no idea on alternatives.

For custom durability system in CustomCrafting's item creator, maybe a NBTMergeExceptAdapter would also works? Like, merge all NBT data except a certain one, like the customized durability, making it looking like item getting fixed.

Additional Context

Above said enchantment plugin: https://www.spigotmc.org/resources/crazy-enchantments.16470/

Custom durability PS: If player fix the item by anvil or command, the durability bar would be fixed. But after any hit, the bar would appear again and be the same as the one before the fix, which is like, rewind.

Submit issue