WolfyScript / CustomCrafting

Spigot based plugin to create your own custom Recipes & Items. Designed to be easy to use with in-game GUI and tons of configuration possibilities.
https://modrinth.com/plugin/customcrafting
GNU General Public License v3.0
114 stars 36 forks source link

(BUG) NBT-Specific stonecutter recipes doesnt work #271

Open MarkinhosMLP opened 1 year ago

MarkinhosMLP commented 1 year ago

What happened?

Custom Model Data and general NBT does not work in stonecutter recipes

for example, im using custom items from oraxen using the filledmap item, and i want lilke, if you use them in the stonecutter you can change them into other furniture but... if you used a normal map you can also use it to change for furnitures and also, you wont get

it also display the wrong item

How can the bug be reproduced?

https://youtu.be/ijDEwx5SM3E

Expected Behaviour?

to work?

Plugin version

4.16.6.4

Server software

Purpur 1.19.4

Relevant log output

No response

Submit issue

WolfyScript commented 1 year ago

There seem to be too issues here.

1. The ingredient (input slot) is not checked for valid NBT

I'll look into this one and try to fix it. As far as I know, I should be able to fix it.

2. The result items (buttons) are mixed & don't align with the actual result

I haven't found a solution for this yet, because it seems to be a Minecraft issue. The Stonecutter GUI simply ignores the NBT of items, meaning the buttons may conflict when they use the same base item. The issue is that it happens on the client side, meaning it would require a client-side mod to be fixed. Maybe I can find some hacky solution that works from the server-side, but I doubt it.