WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.56k stars 4.22k forks source link

Add call to action on classic block #11718

Open bahiirwa opened 6 years ago

bahiirwa commented 6 years ago

I'm always lost when I open my post for editing after installing Gutenberg for a new editing experience. The blob of text just stares at me even on hover.

If the 3 vertical dots icon appeared to show that the block can be edited on hover (Convert to blocks).

Just like the other blocks if the classic block had a simple movement for user experience to show what it is (like the image block that has a blue note saying image)

designsimply commented 6 years ago

Adding some screenshots for reference.

Here is what a post looks like for me when I create it using the classic editor and then open it using Gutenberg—it has a label at top left but it does not appear on hover and is not the same as other blocks which have a blue background and appear at top right:

screen shot 2018-11-11 at 9 40 09 am

Here is the same content after clicking on the classic block:

screen shot 2018-11-11 at 9 40 19 am

Here is a comparison of the block label, which appears top right when hovering, as seen on the image block:

screen shot 2018-11-11 at 9 41 56 am

Seen at http://alittletestblog.com/wp-admin/post.php?post=15656&action=edit running WordPress 4.9.8 and Gutenberg 4.3.0-rc.1 using Firefox 63.0.1 on macOS 10.13.6 .

sarahmonster commented 5 years ago

It looks as though there is a hover state for the block, it's just hiding:

Screenshot 2019-04-02 at 17 30 51

Making the choices more explicit here would be a good call. I just got rather confused trying to find the "convert to blocks" option, which was a bit more separated from the actual content since I had the top toolbar mode enabled. If I got lost and confused, I suspect others might be too.

What about making the choice here more explicit, so it's clear the actions a user has available to them?

Frame

mapk commented 5 years ago

@sarahmonster when I have the Classic Editor plugin "on", I don't seem to get an option for Gutenberg. And the same vice-versa. If I turn the Classic Editor plugin "off" then I get Gutenberg. Would your button "Edit in classic mode" turn the plugin "on"? Or am I missing something entirely here?

I'm curious why we can't just show the Classic block with the full menu (selected view above) when the user opens a classic editor post in Gutenberg.

Why can't it default to this?

Screen Shot 2019-04-05 at 4 53 35 PM

designsimply commented 5 years ago

I think Sarah's design, "Edit in classic mode" means simply open the classic block toolbar (not the plugin which is a separate thing).

I'm curious why we can't just show the Classic block with the full menu

The only reason that comes to mind might be performance related, for example if opening the classic block loads things that do not need to be loaded by default and saves time if they aren't. I know that performance has been a key area of focus.

sarahmonster commented 5 years ago

Would your button "Edit in classic mode" turn the plugin "on"? Or am I missing something entirely here?

My understanding of this issue was that this intermediate state is seen by users who wrote a post using the pre-5.0 editor (the classic editor, in effect) but there may be more complexity here to consider.

If the post was authored using the Classic block, it should (and does) default to showing the Classic block with the full toolbar. But if the post were edited with the pre-5.0 editor, or with the Classic Editor plugin, and the user has since switched to using Gutenberg, it makes sense to provide a clear and easy path to converting to blocks (potentially with the option to undo) or to edit in the Classic block (referred to above as "Classic Mode" mostly because use of "block" is potentially confusing there when sitting next to a "Convert to blocks" option.)

mapk commented 5 years ago

I'd love to see an explicit call to action here. Right now, I have to click the block, then select the vertical dots icon to see the option to "Convert to blocks." And on top of that, once I click the block, the icons are all jacked up. I've reported that here: https://github.com/WordPress/gutenberg/issues/16525

The path to convert this to blocks: Screen Shot 2019-08-21 at 6 47 31 AM

I'm in favor of going with @sarahmonster's mockup:

55420479-0e3b2a00-556f-11e9-8c08-8dea8d8977e3