WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.37k stars 4.15k forks source link

Pinterest URLs not embedding when not .com (.es, .it...) #59400

Closed alvarotrigo closed 2 months ago

alvarotrigo commented 7 months ago

Description

Pinterest URLs that don't come from the .com domain won't be embedded. Pinterest uses a different domain for different countries and people in those countries might find it difficult to use this block.

Step-by-step reproduction instructions

For example, these URLs won't get embedded: https://www.pinterest.es/pin/320670435980314659/ https://www.pinterest.it/pin/308004062030905959/

But changing the .es and .it for .comwill make it work: https://www.pinterest.com/pin/320670435980314659/ https://www.pinterest.com/pin/308004062030905959/

Expected behaviour

Any URL coming from the existing interest domains in each country should work. Having a list of them should be enough to deal with this.

Actual behaviour

URLs won't embed if not coming from the .com domain.

Screenshots or screen recording (optional)

image

WordPress information

interdevel commented 6 months ago

I found that when you try to embed the pin, the URL http://localhost:8888/index.php?rest_route=%2Foembed%2F1.0%2Fproxy&url=https%3A%2F%2Fwww.pinterest.es%2Fpin%2F659566307946923269%2F&_locale=user (using pinterest.es in this case) returns 404. However the actual pin URL (https://www.pinterest.es/pin/659566307946923269/) returns 200.

Mamaduka commented 2 months ago

It looks like the Pinterest embed provider supports those URLs, but the regex used in Core limits URLs to .com(.au|.mx).

@alvarotrigo, can you create a core ticket since this needs to be handled in a different repository?

Example embed - https://www.pinterest.com/oembed.json?url=https://www.pinterest.es/pin/320670435980314659/.

Mamaduka commented 2 months ago

Closing in favor of https://core.trac.wordpress.org/ticket/61558.