Add "skip to content" links to the homepage and the 404 page; fix footer role

obulat commented 1 year ago

Fixes

Related to WordPress/openverse#449 by @obulat Fixes WordPress/openverse-frontend#2179 by @obulat

Description

This PR refactors the default layout to extract footer from the main element, and also adds the "skip to content" links to the pages that use the default layout (homepage and 404 page).

It also sets the content width on 404 page on mobile screens to match the header and footer.

Testing Instructions

Check that the homepage and 404 pages have a "Skip to content" link as the first element of the page.
Check that screenreader announces that the footer is there (and it has "contentinfo" role).

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow [best practices][best_practices].
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

github-actions[bot] commented 1 year ago

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2180 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2180/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

github-actions[bot] commented 1 year ago

Size Change: -5.28 kB (-1%)

Total Size: 877 kB

Filename	Size	Change
`./.nuxt/dist/client/237.js`	1.85 kB	+1.58 kB (+578%)	🆘
`./.nuxt/dist/client/237.modern.js`	0 B	-277 B (removed)	🏆
`./.nuxt/dist/client/238.js`	0 B	-1.85 kB (removed)	🏆
`./.nuxt/dist/client/app.js`	142 kB	+269 B (0%)
`./.nuxt/dist/client/app.modern.js`	116 kB	+253 B (0%)
`./.nuxt/dist/client/commons/app.js`	87.7 kB	+12 B (0%)
`./.nuxt/dist/client/commons/app.modern.js`	78.1 kB	-24 B (0%)
`./.nuxt/dist/client/components/v-homepage-content.js`	1.75 kB	+30 B (+2%)
`./.nuxt/dist/client/components/v-homepage-content.modern.js`	1.72 kB	+27 B (+2%)
`./.nuxt/dist/client/components/v-skip-to-content-container.js`	0 B	-911 B (removed)	🏆
`./.nuxt/dist/client/components/v-skip-to-content-container.modern.js`	0 B	-918 B (removed)	🏆
`./.nuxt/dist/client/pages/audio/_id/index.js`	7.99 kB	-405 B (-5%)	✅
`./.nuxt/dist/client/pages/audio/_id/index.modern.js`	4.83 kB	-420 B (-8%)	✅
`./.nuxt/dist/client/pages/image/_id/index.js`	9.27 kB	-428 B (-4%)
`./.nuxt/dist/client/pages/image/_id/index.modern.js`	7.3 kB	-395 B (-5%)	✅
`./.nuxt/dist/client/pages/image/_id/report.js`	3.63 kB	-588 B (-14%)	👏
`./.nuxt/dist/client/pages/image/_id/report.modern.js`	4.24 kB	-426 B (-9%)	✅
`./.nuxt/dist/client/pages/index.js`	6.88 kB	+29 B (0%)
`./.nuxt/dist/client/pages/index.modern.js`	6.8 kB	+37 B (+1%)
`./.nuxt/dist/client/pages/search.js`	4.46 kB	-595 B (-12%)	👏
`./.nuxt/dist/client/pages/search.modern.js`	1.94 kB	-604 B (-24%)	🎉
`./.nuxt/dist/client/runtime.js`	2.72 kB	-14 B (-1%)
`./.nuxt/dist/client/runtime.modern.js`	2.73 kB	-13 B (0%)
`./.nuxt/dist/client/vendors/app.js`	63.8 kB	-19 B (0%)
`./.nuxt/dist/client/vendors/app.modern.js`	62.8 kB	-170 B (0%)
`./.nuxt/dist/client/236.js`	273 B	+273 B (new file)	🆕
`./.nuxt/dist/client/236.modern.js`	277 B	+277 B (new file)	🆕

ℹ️ View Unchanged

| Filename | Size | Change | | :--- | :---: | :---: | | `./.nuxt/dist/client/components/loading-icon.js` | 748 B | +1 B (0%) | | `./.nuxt/dist/client/components/loading-icon.modern.js` | 748 B | -4 B (-1%) | | `./.nuxt/dist/client/components/table-sort-icon.js` | 509 B | 0 B | | `./.nuxt/dist/client/components/table-sort-icon.modern.js` | 513 B | 0 B | | `./.nuxt/dist/client/components/v-all-results-grid.js` | 7.45 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-all-results-grid.modern.js` | 4.96 kB | 0 B | | `./.nuxt/dist/client/components/v-audio-cell.js` | 389 B | +2 B (+1%) | | `./.nuxt/dist/client/components/v-audio-cell.modern.js` | 388 B | -4 B (-1%) | | `./.nuxt/dist/client/components/v-audio-details.js` | 2.54 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-audio-details.modern.js` | 1.78 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-audio-track-skeleton.js` | 1.01 kB | 0 B | | `./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js` | 1.01 kB | 0 B | | `./.nuxt/dist/client/components/v-audio-track.js` | 5.2 kB | +2 B (0%) | | `./.nuxt/dist/client/components/v-audio-track.modern.js` | 5.15 kB | -4 B (0%) | | `./.nuxt/dist/client/components/v-back-to-search-results-link.js` | 539 B | 0 B | | `./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js` | 542 B | 0 B | | `./.nuxt/dist/client/components/v-bone.js` | 685 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-bone.modern.js` | 689 B | 0 B | | `./.nuxt/dist/client/components/v-box-layout.js` | 1.23 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-box-layout.modern.js` | 1.23 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-content-link.js` | 1.11 kB | 0 B | | `./.nuxt/dist/client/components/v-content-link.modern.js` | 1.09 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-content-page.js` | 467 B | 0 B | | `./.nuxt/dist/client/components/v-content-page.modern.js` | 471 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-content-report-button.js` | 776 B | -3 B (0%) | | `./.nuxt/dist/client/components/v-content-report-button.modern.js` | 780 B | 0 B | | `./.nuxt/dist/client/components/v-content-report-form.js` | 6.1 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-content-report-form.modern.js` | 3.58 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-content-report-popover.js` | 1.23 kB | -4 B (0%) | | `./.nuxt/dist/client/components/v-content-report-popover.modern.js` | 4.23 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-copy-button.js` | 3.98 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-copy-button.modern.js` | 4 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-copy-license.js` | 999 B | 0 B | | `./.nuxt/dist/client/components/v-copy-license.modern.js` | 999 B | -2 B (0%) | | `./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js` | 9.88 kB | +4 B (0%) | | `./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js` | 9.86 kB | 0 B | | `./.nuxt/dist/client/components/v-dmca-notice.js` | 748 B | 0 B | | `./.nuxt/dist/client/components/v-dmca-notice.modern.js` | 752 B | 0 B | | `./.nuxt/dist/client/components/v-error-image.js` | 1.69 kB | +3 B (0%) | | `./.nuxt/dist/client/components/v-error-image.modern.js` | 1.68 kB | 0 B | | `./.nuxt/dist/client/components/v-error-section.js` | 372 B | 0 B | | `./.nuxt/dist/client/components/v-error-section.modern.js` | 375 B | 0 B | | `./.nuxt/dist/client/components/v-external-search-form.js` | 1.91 kB | +2 B (0%) | | `./.nuxt/dist/client/components/v-external-search-form.modern.js` | 1.9 kB | -4 B (0%) | | `./.nuxt/dist/client/components/v-external-source-list.js` | 899 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-external-source-list.modern.js` | 902 B | 0 B | | `./.nuxt/dist/client/components/v-full-layout.js` | 1.51 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-full-layout.modern.js` | 1.51 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-grid-skeleton.js` | 1.61 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-grid-skeleton.modern.js` | 1.62 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-home-gallery.js` | 4.79 kB | 0 B | | `./.nuxt/dist/client/components/v-home-gallery.modern.js` | 4.78 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-image-carousel.js` | 4.73 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-image-carousel.modern.js` | 4.7 kB | 0 B | | `./.nuxt/dist/client/components/v-image-cell-square.js` | 1.02 kB | 0 B | | `./.nuxt/dist/client/components/v-image-cell-square.modern.js` | 1.02 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-image-cell.js` | 1.45 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-image-cell.modern.js` | 1.44 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-image-details.js` | 2.15 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-image-details.modern.js` | 1.42 kB | +2 B (0%) | | `./.nuxt/dist/client/components/v-image-grid.js` | 4.86 kB | +2 B (0%) | | `./.nuxt/dist/client/components/v-image-grid.modern.js` | 2.39 kB | 0 B | | `./.nuxt/dist/client/components/v-license-tab-panel.js` | 521 B | 0 B | | `./.nuxt/dist/client/components/v-license-tab-panel.modern.js` | 524 B | -1 B (0%) | | `./.nuxt/dist/client/components/v-load-more.js` | 3.16 kB | 0 B | | `./.nuxt/dist/client/components/v-load-more.modern.js` | 683 B | 0 B | | `./.nuxt/dist/client/components/v-media-license.js` | 819 B | +2 B (0%) | | `./.nuxt/dist/client/components/v-media-license.modern.js` | 827 B | -1 B (0%) | | `./.nuxt/dist/client/components/v-media-reuse.js` | 1.62 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-media-reuse.modern.js` | 1.61 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-media-tag.js` | 429 B | 0 B | | `./.nuxt/dist/client/components/v-media-tag.modern.js` | 433 B | 0 B | | `./.nuxt/dist/client/components/v-modal.js` | 991 B | 0 B | | `./.nuxt/dist/client/components/v-modal.modern.js` | 981 B | 0 B | | `./.nuxt/dist/client/components/v-no-results.js` | 751 B | 0 B | | `./.nuxt/dist/client/components/v-no-results.modern.js` | 751 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-radio.js` | 1.5 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-radio.modern.js` | 1.47 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-related-audio.js` | 1.25 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-related-audio.modern.js` | 1.25 kB | -5 B (0%) | | `./.nuxt/dist/client/components/v-related-images.js` | 1.05 kB | -1 B (0%) | | `./.nuxt/dist/client/components/v-related-images.modern.js` | 2.95 kB | -2 B (0%) | | `./.nuxt/dist/client/components/v-report-desc-form.js` | 965 B | 0 B | | `./.nuxt/dist/client/components/v-report-desc-form.modern.js` | 967 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-row-layout.js` | 1.7 kB | 0 B | | `./.nuxt/dist/client/components/v-row-layout.modern.js` | 1.71 kB | 0 B | | `./.nuxt/dist/client/components/v-scroll-button.js` | 813 B | 0 B | | `./.nuxt/dist/client/components/v-scroll-button.modern.js` | 818 B | 0 B | | `./.nuxt/dist/client/components/v-search-grid.js` | 5.74 kB | +3 B (0%) | | `./.nuxt/dist/client/components/v-search-grid.modern.js` | 5.66 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-search-results-title.js` | 595 B | 0 B | | `./.nuxt/dist/client/components/v-search-results-title.modern.js` | 598 B | 0 B | | `./.nuxt/dist/client/components/v-search-type-radio.js` | 796 B | 0 B | | `./.nuxt/dist/client/components/v-search-type-radio.modern.js` | 769 B | +1 B (0%) | | `./.nuxt/dist/client/components/v-server-timeout.js` | 299 B | 0 B | | `./.nuxt/dist/client/components/v-server-timeout.modern.js` | 303 B | 0 B | | `./.nuxt/dist/client/components/v-sketch-fab-viewer.js` | 3.37 kB | +1 B (0%) | | `./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js` | 894 B | 0 B | | `./.nuxt/dist/client/components/v-snackbar.js` | 1.18 kB | 0 B | | `./.nuxt/dist/client/components/v-snackbar.modern.js` | 1.19 kB | 0 B | | `./.nuxt/dist/client/components/v-sources-table.js` | 16.1 kB | +9 B (0%) | | `./.nuxt/dist/client/components/v-sources-table.modern.js` | 16.1 kB | +4 B (0%) | | `./.nuxt/dist/client/components/v-warning-suppressor.js` | 298 B | 0 B | | `./.nuxt/dist/client/components/v-warning-suppressor.modern.js` | 303 B | 0 B | | `./.nuxt/dist/client/pages/about.js` | 1.49 kB | 0 B | | `./.nuxt/dist/client/pages/about.modern.js` | 1.5 kB | +1 B (0%) | | `./.nuxt/dist/client/pages/external-sources.js` | 1.51 kB | 0 B | | `./.nuxt/dist/client/pages/external-sources.modern.js` | 1.51 kB | 0 B | | `./.nuxt/dist/client/pages/feedback.js` | 1.29 kB | -2 B (0%) | | `./.nuxt/dist/client/pages/feedback.modern.js` | 1.29 kB | -2 B (0%) | | `./.nuxt/dist/client/pages/preferences.js` | 1.23 kB | -2 B (0%) | | `./.nuxt/dist/client/pages/preferences.modern.js` | 1.22 kB | 0 B | | `./.nuxt/dist/client/pages/privacy.js` | 964 B | +1 B (0%) | | `./.nuxt/dist/client/pages/privacy.modern.js` | 966 B | 0 B | | `./.nuxt/dist/client/pages/search-help.js` | 1.56 kB | 0 B | | `./.nuxt/dist/client/pages/search-help.modern.js` | 1.53 kB | 0 B | | `./.nuxt/dist/client/pages/search/audio.js` | 6.07 kB | 0 B | | `./.nuxt/dist/client/pages/search/audio.modern.js` | 3.58 kB | 0 B | | `./.nuxt/dist/client/pages/search/image.js` | 563 B | 0 B | | `./.nuxt/dist/client/pages/search/image.modern.js` | 2.63 kB | +2 B (0%) | | `./.nuxt/dist/client/pages/search/index.js` | 508 B | 0 B | | `./.nuxt/dist/client/pages/search/index.modern.js` | 514 B | -1 B (0%) | | `./.nuxt/dist/client/pages/search/model-3d.js` | 242 B | 0 B | | `./.nuxt/dist/client/pages/search/model-3d.modern.js` | 246 B | 0 B | | `./.nuxt/dist/client/pages/search/search-page.types.js` | 266 B | 0 B | | `./.nuxt/dist/client/pages/search/search-page.types.modern.js` | 271 B | 0 B | | `./.nuxt/dist/client/pages/search/video.js` | 240 B | 0 B | | `./.nuxt/dist/client/pages/search/video.modern.js` | 243 B | -1 B (0%) | | `./.nuxt/dist/client/pages/sources.js` | 1.53 kB | +1 B (0%) | | `./.nuxt/dist/client/pages/sources.modern.js` | 1.52 kB | 0 B |

_{compressed-size-action}

obulat commented 1 year ago

The Oops in the background has moved, but that is an improvement imo. LGTM!

I couldn't find the up-to-date versions of the 404 mockups to check the Oops position, but couldn't. We could probably adjust them later if needed.

WordPress / openverse-frontend