Open krysal opened 1 year ago
Storybook and Tailwind configuration previews: Ready
Storybook: https://wordpress.github.io/openverse-frontend/_preview/2194 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2194/tailwind
Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.
You can check the GitHub pages deployment action list to see the current status of the deployments.
Size Change: +77 B (0%)
Total Size: 877 kB
Filename | Size | Change |
---|---|---|
./.nuxt/dist/client/pages/search-help.js |
1.6 kB | +44 B (+3%) |
./.nuxt/dist/client/pages/search-help.modern.js |
1.57 kB | +44 B (+3%) |
Playwright Failure Test Results
It looks like some of the Playwright tests failed. You can download the Playwright trace output for both Storybook and Nuxt Playwright tests that have failed at the bottom of this page, under the "Artifacts" section:
https://github.com/WordPress/openverse-frontend/actions/runs/4207702767
Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging
Fixes
Follow up to #2189 and #2191.
Description
Exclude "net" and the related example words on the Search Help page from translations. The comment previously added is not enough, as "net" was also translated in Spanish (almost all variants) to "red", a valid translation, then it made the other words lose sense in the context.
An alternative could be a more elaborated comment on the relation that these words should keep but I'm afraid it might get ignored or overlooked.
Checklist
Update index.md
).main
) or a parent feature branch.[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
Developer Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```