WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
255 stars 204 forks source link

Update node and pnpm #5084

Closed obulat closed 1 month ago

obulat commented 1 month ago

Fixes

Necessary for Storybook Playwright tests to build and pass. See failure in https://github.com/WordPress/openverse/actions/runs/11529074974/job/32097106744?pr=5025

Description

This PR updates the node version to v.22 (which is supposed to become LTS in October 2024), and also updates pnpm

Testing Instructions

Run ov clean and ov init to make sure that your ov node version is updated. Then, all the JS/TS code should work as usual.

Checklist

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
github-actions[bot] commented 1 month ago

Latest k6 run output[^update]

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  8.8 MB/s
     data_sent......................: 837 kB  5.0 kB/s
     http_req_blocked...............: avg=13.69µs  min=1.99µs   med=3.61µs   max=8.01ms  p(90)=5.15µs   p(95)=5.57µs  
     http_req_connecting............: avg=9.35µs   min=0s       med=0s       max=7.97ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=586.3ms  min=37.94ms  med=514.4ms  max=2.39s   p(90)=1.06s    p(95)=1.15s   
       { expected_response:true }...: avg=586.3ms  min=37.94ms  med=514.4ms  max=2.39s   p(90)=1.06s    p(95)=1.15s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=141.36µs min=42.39µs  med=111.4µs  max=29.25ms p(90)=175.96µs p(95)=207.24µs
     http_req_sending...............: avg=20.29µs  min=7.17µs   med=18.92µs  max=2.2ms   p(90)=24.98µs  p(95)=27.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=586.14ms min=37.78ms  med=514.26ms max=2.39s   p(90)=1.06s    p(95)=1.15s   
     http_reqs......................: 6400    37.862442/s
     iteration_duration.............: avg=3.13s    min=767.14ms med=2.59s    max=8.48s   p(90)=6.09s    p(95)=6.44s   
     iterations.....................: 1200    7.099208/s
     vus............................: 3       min=3       max=30
     vus_max........................: 30      min=30      max=30

[^update]: This comment will automatically update with new output each time k6 runs for this PR