github-actions[bot]
commented
1 month ago Latest k6 run output[^update]
✓ status was 200
checks.........................: 100.00% ✓ 6400 ✗ 0
data_received..................: 1.5 GB 9.0 MB/s
data_sent......................: 837 kB 5.1 kB/s
http_req_blocked...............: avg=30.6µs min=1.96µs med=3.63µs max=11.31ms p(90)=5.13µs p(95)=5.51µs
http_req_connecting............: avg=26.24µs min=0s med=0s max=11.25ms p(90)=0s p(95)=0s
http_req_duration..............: avg=573.44ms min=56.81ms med=501.62ms max=2.34s p(90)=1.03s p(95)=1.13s
{ expected_response:true }...: avg=573.44ms min=56.81ms med=501.62ms max=2.34s p(90)=1.03s p(95)=1.13s
✓ http_req_failed................: 0.00% ✓ 0 ✗ 6400
http_req_receiving.............: avg=134.59µs min=41.73µs med=112.76µs max=19.19ms p(90)=176.81µs p(95)=203.43µs
http_req_sending...............: avg=22.43µs min=6.7µs med=18.86µs max=8.3ms p(90)=24.83µs p(95)=26.79µs
http_req_tls_handshaking.......: avg=0s min=0s med=0s max=0s p(90)=0s p(95)=0s
http_req_waiting...............: avg=573.29ms min=56.68ms med=501.37ms max=2.34s p(90)=1.03s p(95)=1.13s
http_reqs......................: 6400 38.608419/s
iteration_duration.............: avg=3.06s min=1.13s med=2.52s max=8.63s p(90)=5.97s p(95)=6.26s
iterations.....................: 1200 7.239079/s
vus............................: 9 min=9 max=30
vus_max........................: 30 min=30 max=30[^update]: This comment will automatically update with new output each time k6 runs for this PR
openverse-bot
AetherUnbound
Fixes
Fixes #4998 by @obulat
Description
This PR adds CSS variables for the contrasting text color and for the focus ring color so that the logo elements (
VWordPressLinkandVHomeLink) do not use JS to determine colors, even when the colors don't match the current color mode (i.e., on the pages modal, which has black background both in the dark and in the light themes).To prevent some of the focus styles overriding each other, I changed
focus-slim-txclass to only apply onfocus-visible. Otherwise, it changes the ring color not only for the element in question, but for child elements, and sometimes is difficult to override.Testing Instructions
Run the app using
ov just frontend/run devOpen http://localhost:8443 in a narrow window, and click on the menu button in the top right corner. Use the keyboard to navigate though the contents. The focus rings should be yellow, in dark and in light themes. The WordPress and Openverse links should have correct colors.Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalog PRs) or the media properties generator (ov just catalog/generate-docs media-propsfor the catalog orov just api/generate-docsfor the API) where applicable.[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
Developer Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```