WordPress / wp-feature-notifications

WP Feature Notifications - a proposal to modernise the way in which WordPress handles emails, admin notices and user notifications
https://wordpress.github.io/wp-feature-notifications/
GNU General Public License v2.0
188 stars 18 forks source link

Multisite Support #64

Open Sephsekla opened 3 years ago

Sephsekla commented 3 years ago

Do we have a plan in place for how notifications will be handled on a multisite installation? It would be great to be able to see notifications from multiple sites in a network in one place. Maybe on a multisite install we could add an extra indicator to each notification to show which site it refers to.

raaaahman commented 3 years ago

This is probably tied to the recipients. Only the super admin role should be notified about actions happening on every sites.

Maybe on a multisite install we could add an extra indicator to each notification to show which site it refers to.

Yes, probably.

Maybe there is also the severity to take into account: should we notify the super admin about any matter that is less than critical for other sites of the network?

In the end, if it is a matter of only warning the super admin about critical failures in the network, then this could be a feature we can add later rather than defining a characteristic of the system.

Sephsekla commented 3 years ago

In an ideal world it would be good to have an option to configure that - I'm not sure there's a right answer as opposed to just case by case preferences. It could be a dashboard setting, or even just a filter to start with.

jonathanbossenger commented 3 years ago

Is it possible that what we have currently is sufficient for a multisite network?

The notification originator (core, plugin, theme) can determine a) if this is a multisite network and b) who the super admin is, and create a notification for them. The notification originator can then include a) whether this notification pertains to the network, or a specific site, and b) if needed, the specific site it pertains to, either by adding this to the title or message for the notification.

Given this, are there any situations we can think of where what we have available in the notification schema would not be enough for a multisite-related notification?

raaaahman commented 3 years ago

The notification originator (core, plugin, theme) can determine a) if this is a multisite network and b) who the super admin is, and create a notification for them. The notification originator can then include a) whether this notification pertains to the network, or a specific site, and b) if needed, the specific site it pertains to, either by adding this to the title or message for the notification.

The origin site information could indeed pertain in the Sender model. But that would still need to be added to the current Sender model.

Sephsekla commented 3 years ago

It may be that it's mainly a frontend display consideration then. I think these are the key points to consider:

folletto commented 3 years ago

Here's a basic idea that I think fits very well the model.

Both are determined by the specific notification level on the originating site: if the site delivers a in-hum notification to a specific user role, then it will be delivered regardless of site.

I think this can be later be reviewed, but I think it's the baseline starting point we can ship, then refine.

One thing design wise that comes out of it is that on multi-site installation we might need to review how clear it is the site source. Might already work with what we have, but definitely something to check.

Sephsekla commented 2 years ago

This was raised again when I demoed the POC plugin last week. We discussed the possibility of a select/filter control for notification source, so this could tie together nicely #84