WordPress / wp-plugin-dependencies

WordPress Feature Project: Plugin Dependencies
https://make.wordpress.org/core/2022/02/24/feature-project-plugin-dependencies/
MIT License
69 stars 9 forks source link

Installing dependency from modal on plugin page should refresh plugins list #20

Open mrwweb opened 2 years ago

mrwweb commented 2 years ago

Instructions

  1. Install a plugin with a dependency
  2. On Plugins > Installed Plugins, click the link of a dependent plugin in the "Requires: {Plugin}" list
  3. Click "Install Now" in the modal to install the plugin

Actual Outcome

The dependent plugin is installed but the plugin is not listed in the list of plugins until the page is refreshed

Expected Outcome

The dependent plugin is listed in the list of plugins and the plugin with dependencies has its options updated to reflect the installed dependency

afragen commented 2 years ago

Thanks for testing.

Unfortunately that is the expected outcome. The modal is an iframe and the page doesn't refresh automatically. This is all current core function and not specific to this plugin. The modal is the same for any View details modal that you would fine anywhere.

You should try installing the dependencies from the Dependencies tab in the Install Plugins page.

mrwweb commented 2 years ago

You should try installing the dependencies from the Dependencies tab in the Install Plugins page.

I tried that too and it worked fine.

This mostly feels like a bug because of some of the other ways that the messaging and display don't always give a clear forward path for acting on a dependency.