search

WorldWideTelescope / pywwt

Python interface to WorldWide Telescope :milky_way:
https://pywwt.readthedocs.io
BSD 3-Clause "New" or "Revised" License
51 stars 15 forks source link

Make qtpy dependency optional #376

Closed Carifio24 closed 6 months ago

Carifio24 commented 6 months ago

Downstream in glue-wwt we're trying to make qtpy be an optional dependency (https://github.com/glue-viz/glue-wwt/issues/111) so that it doesn't need to be installed to use the WWT Jupyter viewer. To help make that possible, this PR makes qtpy an optional dependency of pywwt, moving it to the qt and qt6 install options.

The documentation already makes it sound like qtpy is an optional dependency, so I don't think it needs to be changed at all?

Carifio24 commented 6 months ago

CI failures are the same as in #375; I can rebase once we finish sorting that out.

pkgw commented 6 months ago

Looks like you'll need to rebase to make ReadTheDocs happy.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.51%. Comparing base (5ec4686) to head (22117b7). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ======================================= Coverage 56.51% 56.51% ======================================= Files 25 25 Lines 2872 2872 ======================================= Hits 1623 1623 Misses 1249 1249 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.