search

WrenSecurity / wrenidm

Community‐developed identity management system with a flexible data model, multiple extension points and scripting support, including JavaScript and Groovy.
https://wrensecurity.org/
Other
40 stars 19 forks source link

Linked view ends with a global exception if there is something wrong with a linked resource #7

Closed smolafilip closed 6 years ago

smolafilip commented 7 years ago

This issue is in historical/release/4.5.0, it is already fixed in develop

Right now the linkedView gets its data from SynchronizationService#getLinkedResources. When this method is unable to resolve the resource (either the connector is not available, the resource is not available, or in case of other connector exception) the whole request ends with an error. This is not optimal, because the error is then propagated to the administration interface as "Unexpected error... contact administrator".

It would be preferable (and in my opinion correct) to return errors for each fetched resource, so that the client (the administration interface) can decide what to display.

The solution could be to, instead of throwing an exception, set the exception as an attribute of the linked resource and set the resource content itself to null. This is properly handled by the administration interface and would thus require no change in that part of the application.

karelmaxa commented 6 years ago

I'm closing the issue because related pull request (https://github.com/WrenSecurity/wrenidm/pull/20) has already been closed. Historical release 4.5.0 is not supported anymore. Issue should be fixed in master.