Wurst-Imperium / Wurst7

Minecraft Wurst Hacked Client v7
https://www.wurstclient.net/download/?utm_source=GitHub&utm_medium=Wurst+Client&utm_content=Wurst7+GitHub+repo+sidebar+website+link
GNU General Public License v3.0
1k stars 416 forks source link

MobOwner Cheat #608

Open RealmKebab opened 2 years ago

RealmKebab commented 2 years ago

Before posting, please make sure that this hasn't already been suggested by someone else.

Description

This cheat is pretty useful for 1.18 or below versions anarchy servers and some random "SMP" servers. And this cheat appears in alot of clients, so I want it added to this one.

What it does is: If you don't have OP on the server, you can't see mob owner's without the /data get entity command.

Instead of that, The module will display a overhead nametag with the owner of mob's name displaying

Example: Wolf, Tamed by Notch Name above it: Owned By Notch insert wolf here Any mob that is tameable and is tamed will be displayed with the owner of the mobs name. Speific Colors for the name:

Red if the player is not on the server

Green is the player IS on the server.

Screenshots / Videos (Optional)

I have no idea how to send a large file so I'm not using screenshots or videos. Or just use another client and see how it looks like.

sudofox commented 2 years ago

Just a heads up that the owner is stored in the entity data as a UUID which requires making an API call to Mojang to resolve it to a username. As an end user, you might want to look at WTHIT or other mods that provide additional info (there is a PetOwner one).

If this does get added, care should be taken to handle situations in which we're unable to reach the Mojang API e.g playing when not connected to the internet and taming an animal, or looking at a world download

ThisTestUser commented 1 year ago

Here's my implementation of your idea: https://github.com/ThisTestUser/Wurst7/commit/fb3e433e15627f9eab89546a949eecd38bcca30d

If the API cannot be reached, it just displays the UUID. This can also happen if the server is in offline mode, which is why the mod will also try to resolve the player name from the tab list.

RealmKebab commented 1 year ago

Here's my implementation of your idea: ThisTestUser@fb3e433

If the API cannot be reached, it just displays the UUID. This can also happen if the server is in offline mode, which is why the mod will also try to resolve the player name from the tab list.

How long would this take or has it been completed?

ThisTestUser commented 1 year ago

You can download the 1.19.2 version of Wurst with this feature from my repo: https://github.com/ThisTestUser/Wurst7/releases

RealmKebab commented 1 year ago

Just a heads up that the owner is stored in the entity data as a UUID which requires making an API call to Mojang to resolve it to a username. As an end user, you might want to look at WTHIT or other mods that provide additional info (there is a PetOwner one).

WTHIT requires itself to be on server to see who is the owner of the pet, Simple reason why it won't wont work (for wthit) If you own that pet, wthit WILL be able to tell you own it. But any pet owned by others? No, It won't be able to tell you.

RealmKebab commented 1 year ago

I have no absolute idea if this feature is being worked on or not, but i'll wait since patience is an important key.

Alexander01998 commented 1 year ago

I appreciate your patience but I want to set expectations correctly. I'm not currently working on a MobOwner feature. Right now, my primary focus is on setting up a forum for the Wurst community, as our subreddit has suddenly become unusable with the recent Reddit API changes. This is a bit of an emergency, so I've had to put everything else on hold for now.

Once the forum is successfully up and running, my aim will be to work on and implement some of the most popular feature requests that received a lot of upvotes on the recent Wurst 7.36 voting post. Unfortunately, MobOwner didn't receive any votes there, so it probably won't be included in the v7.36 update.

However, maybe it will gain popularity in a future poll? I learnt a lot from the 7.36 post and I definitely plan to keep doing these polls on the forum (once I figure out how to replicate Reddit's contest mode).

RealmKebab commented 1 year ago

Alright 👍

ThisTestUser commented 1 year ago

I already have a MobOwner feature created (as MobInfo), but I'm waiting for #801 to be merged first.

Cyclopropinon commented 1 year ago

lets hope it will be soon

github-actions[bot] commented 9 months ago

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

Alexander01998 commented 9 months ago

Still relevant.

RealmKebab commented 8 months ago

This now would be actually more useful for operators and normal players since mojang somehow screwed up the /data get entity <EntityID> Owner Output of the command: image

github-actions[bot] commented 6 months ago

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

Alexander01998 commented 6 months ago

Still relevant.

The /data get command now returns the UUID as an array of 4 integers, but luckily calling wolf.getOwnerUuid() still returns the UUID in its usual format. This means existing MobOwner implementations should not be affected.

For displaying the owner, we need a system that can display custom nametags similar to the one proposed in #801, but with better support for multiple tags. #801's current system with the manual vOffset parameter is not sophisticated enough to ensure that multiple tags coming from different hacks won't overlap or have gaps between them.

coolnoob78 commented 2 weeks ago

any updates on this?