search

Wykks / ngx-mapbox-gl

Angular binding of mapbox-gl-js
https://wykks.github.io/ngx-mapbox-gl
MIT License
347 stars 141 forks source link

ESM support #425

Open datzgit opened 2 months ago

datzgit commented 2 months ago

Hello everyone!

After upgrading to latest version which supports Angular 18, when I build my project I receive this CommonJS warning regarding ngx-mapbox-gl module:

▲ [WARNING] Module 'mapbox-gl' used by 'node_modules/ngx-mapbox-gl/fesm2022/ngx-mapbox-gl.mjs' is not ESM

CommonJS or AMD dependencies can cause optimization bailouts. For more information see: https://angular.dev/tools/cli/build#configuring-commonjs-dependencies

Will there be any update on this, or should I follow the instructions from the link above mentioned in order to ignore this warning?

MaximBelov commented 3 weeks ago

https://github.com/Wykks/ngx-mapbox-gl/pull/429