search

WyliodrinEmbeddedIoT / tockloader-rs

Other
0 stars 2 forks source link

Update tbf-parser #22

Open george-cosma opened 3 weeks ago

george-cosma commented 3 weeks ago

The TBF Parsing library is slightly out of date from the original from tock. Updating it immediately is not possible because several additions have been made to the current version so that it works with &[u8] that are not 'static.

In the mean time, only one addition to the spec has been made: types::TbfHeaderTypes::TbfHeaderShortId

Here is the update log: https://github.com/tock/tock/commits/master/libraries/tock-tbf. The current version is probably based on some commit from a year ago.

We have several question to answer:

  1. How should we introduce the TbfHeaderShortId? Should we hand-roll the implementation based on the official implementation?
  2. How do we want to keep up with future updates?
  3. Is it worth upstreaming our changes with no static?
george-cosma commented 3 weeks ago

To view the differences:

  1. Check out the main branch on this repo. (Make sure everything you have is commited!)
  2. Download this: update.patch
  3. Then git apply update.patch
  4. Then observe the changes yourself