Ensure consistency of data between proxy VIP units and the original units

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495

MIT License

60 stars 68 forks source link

Ensure consistency of data between proxy VIP units and the original units #465

Open pledbrook opened 5 years ago

pledbrook commented 5 years ago

XComGameStateContext_StrategyGameRule.CleanupProxyVIPs ensures that the death and injured status of VIPs are copied across to the corresponding Avenger units, but that's it. One important piece of information that's missing is whether the unit actually left the mission successfully, such as via an evac.

Other things to consider are kill counts, particularly if you have soldier VIPs that can shoot on missions. But perhaps they don't use proxies.

Iridar commented 3 years ago

I see this issue mentioned in comments in Highlander's code, though not sure which PR added it. In any case, please add docs so this issue can be closed.

Xymanek commented 3 years ago

The PR is #466