search

XPixelGroup / DiffBIR

Official codes of DiffBIR: Towards Blind Image Restoration with Generative Diffusion Prior
Apache License 2.0
3.28k stars 278 forks source link

Will other samplers be supported in the future? #48

Open IDKiro opened 1 year ago

IDKiro commented 1 year ago

I noticed that you've removed the DDIM option in the current version of the code, even though it didn't seem to work in the initial version. Sampling efficiency is one of the obstacles to practicality, especially for high-resolution images. Will DDIM and DPM-Solver samplers be supported in the future?

IDKiro commented 1 year ago

I conducted experiments applying DDIM and DPM-Solver and found that they performed very poorly. After debugging, I found that ODE-based samplers inherently couldn't reconstruct images similar to the conditional images. I tried setting the eta of DDIM to 1.0, and obtained results similar to those from the Spaced Sampler. Did you also remove DDIM based on similar experimental observations?

0x3f3f3f3fun commented 1 year ago

Yes! We find that the DDIM sampler will produce unpleasant results and we don't know what the reason is.

IDKiro commented 1 year ago

This is an interesting question. If you come across any new findings in the future, I hope you'll let me know. I'm also planning on exploring this area further in the upcoming period.