fix: fix network ID tests + refactor network ID logic - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

145 stars 83 forks source link

fix: fix network ID tests + refactor network ID logic #655

Closed mvadari closed 9 months ago

mvadari commented 9 months ago

High Level Overview of Change

Title says it all.

Context of Change

Tests are failing because the sidechain devnet no longer has a network ID greater than 1024.

Type of Change

[x] Refactor (non-breaking change that only restructures code)
[x] Tests (You added tests for code that already exists, or your new feature included in this PR)

Did you update CHANGELOG.md?

[ ] Yes
[x] No, this change does not impact library users

Test Plan

The network ID tests now work.