feat(contributing): update model script to process ledger objects - Githubissues

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain

ISC License

151 stars 86 forks source link

feat(contributing): update model script to process ledger objects #681

Closed mvadari closed 4 weeks ago

mvadari commented 9 months ago

High Level Overview of Change

This PR updates the generate_tx_models.py script to also add ledger object models to xrpl-py. (and renames it to generate_models.py).

Context of Change

Helping review #663. This should probably only be merged after that PR is merged.

Type of Change

[x] New feature for contributors

Did you update CHANGELOG.md?

[x] No, this change does not impact library users

Test Plan

The script runs properly and generates good models for all the existing ledger objects.

ckeshava commented 4 weeks ago

@mvadari The linked PR (titled: Add Ledger Objects) is no longer maintained. What do you propose to do with this PR's changes?