search

XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
112 stars 11 forks source link

Any interest in extracting out a library and/or creating a regular HA integration? #157

Open tringenbach opened 2 weeks ago

tringenbach commented 2 weeks ago

Would you be interested in extracting / publishing a library to talk to Qolsys?

To me, AppDaemon and MQTT add extra complexity. I'd rather have a more tradition Home Assistant integration. I assume you feel differently, since you implemented things the way you did.

It looks like your code is structured really well, and that the https://github.com/XaF/qolsysgw/tree/main/apps/qolsysgw/qolsys directory already is effectively a library to talk to a qolsys panel. I was wondering if you'd consider publishing it as a library, so that I could import it and try my hand at creating the Home Assistant integration that I think I would prefer.

If you're on the fence, I could copy/paste it into my own project for now, and if/when I actually produce something, we could revisit this discussion.

pelebel commented 2 weeks ago

Maybe not relying on MQTT could open up a way to get access to the camera? I would support that project.

tringenbach commented 2 weeks ago

Maybe not relying on MQTT could open up a way to get access to the camera? I would support that project.

Is the camera exposed over the Control4 https connection that this project uses?

There's a Ring doorbell third party add-on that I also use that also uses mqtt and supports video. I don't actually use that one all that much so I haven't looked into how it works. Anyway, I guess I'm saying I wouldn't expect MQTT to be the limitation on camera support.

XaF commented 1 week ago

Hello!

I'd be open to do that - might not have time for it in the next few weeks but I should be able to do it before the end of the summer.

To answer the question about why it is done with appdaemon right now, one reason is that maintaining the connection to the qolsys panel is not something nice to handle as part as a heavier tool, meaning also that each restart of home assistant will trigger reloading the information from the panel and prevent maintaining a state, while appdaemon allows for this to be entirely separate.

I don't have any intent on blocking people from doing things differently at all, and if I can make things easier by extracting qolsysgw as a library, so be it! It's nicer to have shared code that can take advantage of many people trying to improve it instead of each having their code in their own repo.