Xabaril / AspNetCore.Diagnostics.HealthChecks

Enterprise HealthChecks for ASP.NET Core Diagnostics Package
Apache License 2.0
4.12k stars 800 forks source link

Update MongoDB.Driver Package Version To 2.28.0 #2266

Closed Alirexaa closed 4 months ago

Alirexaa commented 4 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #2265

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

adamsitnik commented 4 months ago

it seems that we should be able to sign the library now.

@eerhardt this will allow for signing the Aspire package as well. But I can not find SignAssembly in the Aspire repo. Does it mean you have given up on the signing?

eerhardt commented 4 months ago

it seems that we should be able to sign the library now.

@eerhardt this will allow for signing the Aspire package as well. But I can not find SignAssembly in the Aspire repo. Does it mean you have given up on the signing?

We just ignore the signing warning in our repo:

https://github.com/dotnet/aspire/blob/d8369e0d6e579127fd47681342b96e14e057df9a/src/Components/Aspire.MongoDB.Driver/Aspire.MongoDB.Driver.csproj#L9

    <NoWarn>$(NoWarn);CS8002</NoWarn> <!-- MongoDB packages are not signed -->
Jaben commented 3 months ago

@adamsitnik Any ETA for when this will be released? Thanks!

Alirexaa commented 3 months ago

@unaizorrilla we need a new release here.

ledouxpl commented 3 months ago

@adamsitnik Could you please prioritize releasing the patch? It's currently preventing us from updating the MongoDB C# driver in our organization without having to take down the health checks.

JacobAtchley commented 3 months ago

@adamsitnik Could you please prioritize releasing the patch? It's currently preventing us from updating the MongoDB C# driver in our organization without having to take down the health checks.

+1 we are also facing the same issue

@adamsitnik