Fix compilation on msys2/mingw

XboxDev / extract-xiso

Xbox ISO Creation/Extraction utility. Imported from SourceForge.

http://sourceforge.net/projects/extract-xiso/

Other

705 stars 88 forks source link

Fix compilation on msys2/mingw #30

Closed thrimbor closed 5 years ago

thrimbor commented 5 years ago

Compilation on msys2/mingw was broken due to multiple conflicting definitions/declarations of asprintf. Fixed by disabling the included asprintf when non-MSVC is detected on Windows.

JayFoxRox commented 5 years ago

Was this tested only with MSYS2, or also MSVC?

thrimbor commented 5 years ago

Was this tested only with MSYS2, or also MSVC?

Building was tested with both, creating an xiso only with MSYS2.

JayFoxRox commented 5 years ago

I didn't test this, but this appears low-risk to me. We shouldn't be so slow on such minor PRs. More tests and reviews would be nice for future PRs.