XboxDev / extract-xiso

Xbox ISO Creation/Extraction utility. Imported from SourceForge.
http://sourceforge.net/projects/extract-xiso/
Other
705 stars 88 forks source link

Remove FTP #7

Closed GXTX closed 6 years ago

GXTX commented 6 years ago

As a request in issue #4 this commit will remove all traces of FTP from the program.

Apologies for the full file rewrite, seems GitHub doesn't want to show what really has changed, an online diff viewer shows the correct changes to extract-xiso.c.

This is untested in the sense I have not used it to extract or create and xiso's, i've only built it on Windows & Ubuntu.

mborgerson commented 6 years ago

Thanks for handling this issue! The reason it looks like you've done a full rewrite of some of the files is due to the fact that your editor (or possibly Git) has converted the file to use Windows style line endings instead of Unix style. Fortunately there are ways to fix this. The code changes to extract-xiso.c otherwise look good from my brief glance.

I need you to do a couple of things before I can merge this:

  1. Please correct the line endings issue per this page There's also dos2unix. Reach out if you need help with this.
  2. Please perform a test of your changes (just compiling is not sufficient testing for a change like this). Since you have built on Windows and Ubuntu, it should be quite easy to do: (a) Generate an xiso before your change containing some files x, y, z (b) After applying your change, create another xiso with the same files. (c) Hash the old and new files (sha256sum or something) and check that they are equal (d) Test extraction by extracting the contents of one of the xisos and making sure the contents match the original files.
GXTX commented 6 years ago

ISOs are able to properly be created from both a retail/debug build in Linux and Windows. Hashes for ISO's created are NOT the same however both properly load in XQEMU - this is the same as previous commits, extracted files are identical to the source files.

Line ending are fixed.

mborgerson commented 6 years ago

Thanks!