Xeeynamo / sotn-decomp

Decompilation of Castlevania: Symphony of the Night (PSX+Saturn)
https://sotn.xee.dev/
GNU Affero General Public License v3.0
480 stars 55 forks source link

Make config stage fixes #1657

Closed Xeeynamo closed 4 days ago

Xeeynamo commented 4 days ago

Fixes a few issues found by @bismurphy where certain symbols that were not supposed to be added, were added.

The major fix is when the second pass found a meaningful symbol name like MakeExplosion, the third pass could add a new symbol with the same offset but with the default splat name func_8019055C. With the new add_symbol_unique the symbol table will stay unique. On top of that when adding a new symbol func_8019055C can be replaced by MakeExplosion but not the other way around. This will ensure only meaningful names will be resolved.