search

Xeverous / filter_spirit

Advanced item filter generator for Path of Exile that uses it's own DSL and online item price APIs
GNU General Public License v3.0
36 stars 7 forks source link

refactor to new influence types in parsing data from poe.ninja and poe.watch #31

Closed Xeverous closed 4 years ago

Xeverous commented 4 years ago

There is still some code from before 3.9 Atlas update, having some assumptions that are no longer true:

https://github.com/Xeverous/filter_spirit/blob/54252f14910a118a816220ecad43479fb7a78d1f/src/lib/fs/network/poe_watch/parse_data.cpp#L328-L334

At worst, some items will be incorrectly considered as invalid (and ignored) but since FS does not yet support querying for complex items (see #10) this does nothing more than producing some badly looking logs.

Xeverous commented 4 years ago

Done in b13b4d12f80c76c00dc637fedb357984f0cbd4a9.