XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

Show line highlighting always #112

Closed oezgueremir closed 9 years ago

oezgueremir commented 9 years ago

Show line highligting even if editor window does not have the focus.

This is a quickfix. I can build a version with extended menu switching support for highlighting "off", "when focused" or "always", if you would prefer this solution...

XhmikosR commented 9 years ago

I don't know if this behavior is better or not. I mean, it doesn't seem any other program doing the same...

oezgueremir commented 9 years ago

If you look at the highlighting as some "marked text", the changed behavior is more accurate.

For example, when you have to check a large list line by line and you have to open another window side by side to the editor, you have to mark each line by hand to see your current line. To be honest, this was the primary reason for my change request...

XhmikosR commented 9 years ago

But it's non standard behavior as far as I can tell. I haven't seen any other program doing that...

oezgueremir commented 9 years ago

Of course, this is your project. But with all due respect, you are talking about "standard behaviors" for an application that should replace a "standard tool" (notepad) .

Please take a look at my PR, you will clearly see, that I am using a define that is fully implemented by scintilla. I think they saw, that this feature could be useful.

Again, the "marked text" and the "marked occurrences" are still shown in the non-focused state. I just wanted to see some steadiness.

I am willing to work on the enhanced solution I mentioned in my opening post. But only if there is a chance that this will be merged.

XhmikosR commented 9 years ago

Again, it's non standard, i.e. no other program I'm aware of is doing that, so I don't see this being merged.

oezgueremir commented 9 years ago

Thanks for that answer.