search

XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

Added missing HTML and CSS keywords. #47

Closed Phanx closed 11 years ago

XhmikosR commented 11 years ago

@phanx: I also wonder like @QWp6t does why you removed some keywords... Removing keywords doesn't really make sense because even if something is deprecated, there is code around that uses them.

But maybe you had another reason in mind.

Phanx commented 11 years ago

I did remove a few keywords that have been deprecated since HTML 3.2 or earlier. HTML 3.2 was published in January 1997, and was replaced by HTML 4 in December 1997. If there is really any code still around that hasn't been updated since 1997, it's certainly not being maintained, and if someone is actually looking at it, tags that haven't been part of any HTML standard for 16 years deserve to be highlighted as invalid/unknown tags.

You'll notice that I left plenty of keywords that were deprecated in HTML 5, as that's much more recent (2008) and it's reasonable that there's still a large volume of HTML 4 code being maintained, or even generated by stuff like MS Word.

XhmikosR commented 11 years ago

Still, I'd rather not remove the keywords.

Phanx commented 11 years ago

Well, you should add blink and marquee and all the other 1995-era nonsense too, then.

XhmikosR commented 11 years ago

No reason to do that. I just won't remove existent keywords.

Phanx commented 11 years ago

Why leave it halfway? If you care about people working with 16-year-old code, you should either support all the "deprecated since 1997" keywords, or none of them. Supporting some at random seems like a really strange choice.

XhmikosR commented 11 years ago

Because this is a fork. Since the keywords are in Notepad2, I'm not going to remove them. They don't cause any issues after all, it's just extra code which can be removed at some point.

XhmikosR commented 11 years ago

Closing in favor of https://github.com/XhmikosR/notepad2-mod/pull/48