search

XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

Line height #96

Closed reyaz006 closed 10 years ago

reyaz006 commented 10 years ago

My complain is that line height is rather tall when compared to Windows Notepad.

I'm using font Consolas,11. Measured line height in Notepad - 18px, in Notepad2-mod - 21px.

Is there any way to change this?

XhmikosR commented 10 years ago

Doesn't the same happen with Notepad2 4.2.25? If so, then it's an upstream issue and you should report it there.

oezgueremir commented 10 years ago

Hi!

You may change the default "extra line spacing" (=2) in your custom schemes

extra line spacing

Unfortunately, the minimum of zero gets you to the result of 19px height... There is still one extra pixel remaining above the characters.

To get a more acurate result, you have to optimize the following scintilla function, I think. In ViewStyle.cxx: void ViewStyle::FindMaxAscentDescent()

Good luck!

reyaz006 commented 10 years ago

Thanks so much! I had no idea that there is a separate option for that. 19 vs 18 is not a big issue so that works for me.

I've tried Notepad2 4.2.25 and it's all same there. But now that it's about just 1 pixel, I don't think it's worth anyone's attention.

oezgueremir commented 10 years ago

Not a single problem, you're welcome ;-) Please close the issue, when you think it is solved

XhmikosR commented 10 years ago

Thanks @oezgueremir for the help!