Closed hycdong closed 2 years ago
bulk_load_node_max_ingesting_count
- restrict node max ingesting partition count
Actually, if you restrict disk count
, bulk_load_node_max_ingesting_count
seem to be useless, it's ok that you just control disk load.
I think it's more complex to consider two count
, you can consider that just use one count
whether more simple?
bulk_load_node_max_ingesting_count
- restrict node max ingesting partition countActually, if you restrict
disk count
,bulk_load_node_max_ingesting_count
seem to be useless, it's ok that you just control disk load.I think it's more complex to consider two
count
, you can consider that just use onecount
whether more simple?
+1, I think max_ingesting_count_per_disk
can meet demands, 2 options to restrict bulkload will increase the burden of understanding.
@Shuo-Jia @Smityz Thanks for your suggestions~ I meant to define only one configuration called max_disk_ingesting_count
, but used the node_count+disk_count
, there are two reasons:
config_context
, meta server even doesn't store the disk count of a replica server. Meta server can only traversal each partition's config_context
structure, then calculate how many disks a replica server have. disk_count
) is a easier and more graceful way.
As https://github.com/apache/incubator-pegasus/issues/886 shows, we plan to provide a disk-level concurrent ingesting count restriction. This pull request adds a new class called
ingestion_context
, recording the ingesting partitions and every node and disk ingesting count.This pull request also adds two configurations to implememt the restriction:
bulk_load_node_max_ingesting_count
- restrict node max ingesting partition countbulk_load_node_min_disk_count
- node min disk countFor example:
node_max_count=1
,disk_count=3
: only one partition can do ingestionnode_max_count=3
,disk_count=3
: each disk can only have one partition do ingestionnode_max_count=4
,disk_count=3
: each disk can have 2 partitions do ingestion, but node concurrent count is 4Configuration changes