andresa-xilinx
commented
7 months ago Before applying the patch:
andresa@sup-cap1:~/onload-patches/tcpdirect$ ZF_ATTR="emu=2;interface=enp129s0f0" ./build/gnu_x86_64-zf-devel/bin/zf_unit/zfattrs
1..100
# attr test bitmask 0x20cca
ok 1 - Data sent
ok 2 - Correct data received
# attr test bitmask 0x5ab26
ok 3 - Data sent
ok 4 - Correct data received
# attr test bitmask 0x323f4
ok 5 - Data sent
ok 6 - Correct data received
# attr test bitmask 0x38dbd
ok 7 - Data sent
ok 8 - Correct data received
# attr test bitmask 0x6927f
ok 9 - Data sent
ok 10 - Correct data received
# attr test bitmask 0x1a22a
ok 11 - Data sent
ok 12 - Correct data received
# attr test bitmask 0x2cfd4
ok 13 - Data sent
ok 14 - Correct data received
# attr test bitmask 0x4b20
ok 15 - Data sent
ok 16 - Correct data received
# attr test bitmask 0x50269
ok 17 - Data sent
ok 18 - Correct data received
# attr test bitmask 0x3348e
ok 19 - Data sent
ok 20 - Correct data received
# attr test bitmask 0x71b2f
ok 21 - Data sent
ok 22 - Correct data received
# attr test bitmask 0x1bf39
ok 23 - Data sent
ok 24 - Correct data received
# attr test bitmask 0x293d3
ok 25 - Data sent
ok 26 - Correct data received
...
# attr test bitmask 0x4627a
ok 95 - Data sent
ok 96 - Correct data received
# attr test bitmask 0xc369
ok 97 - Data sent
ok 98 - Correct data received
# attr test bitmask 0x5620d
ok 99 - Data sent
ok 100 - Correct data received
abower-amd
ligallag-amd
pemberso-xilinx
Originally, the customer reported that log_level and log_format could not be set using zf_attr_set_int(). They requested that an error be returned instead of allowing the operation to seemingly succeed without effect.
Upon inspecting the zf_attr_set_int and zf_attr_set_str code, as well as the unit test zfattrs.c, we found that the attributes log_level, log_format, and log_file never worked as intended. These are global attributes that were not only impossible to set programmatically but also kept resetting every time a new set of attributes was allocated within the app. Additionally, when zf_attrget was used, the local attributes within the set and the corresponding zflog variables were not synchronized.
The unit test did not show the expected headers and logs when the attributes were set in the set_test_attrs function in zfattrs.c. I have added specific tests to guarantee synchronization between local and global attributes across different instantiations of new attribute sets.
We see no reason to forbid the programmatic initialization of these parameters using zf_attr_set_int(). The existing unit test (zfattrs.c) works as expected after applying this patch.