search

Xilinx / Vitis_Libraries

Vitis Libraries
https://docs.xilinx.com/r/en-US/Vitis_Libraries
Apache License 2.0
894 stars 356 forks source link

[2023.2] CONFIG_FILE and CONFIG_TMPL variables in makefile of examples #194

Open brucebenedictus opened 8 months ago

brucebenedictus commented 8 months ago

Hi,

I want to run the the HLS examples in the 2023.2 branch. The makefile in the examples use the environment variable CONFIG_FILE and CONFIG_TMPL. My infrastructure uses these environment variables already.

Would it be possible not to check if the variables are already set?

vermaete commented 8 months ago

just to append to the issue of Bruce

The issue here is that gitlab-ci is using the CONFIG_FILE variable too. https://docs.gitlab.com/runner/commands/#configuration-file And probably many others.

Putting a kind of namespacing to the global Vitis variables (e.g. 'xlnx' or 'vitis') could solve this.

br