Xilinx / XRT

Run Time for AIE and FPGA based platforms
https://xilinx.github.io/XRT
Other
561 stars 477 forks source link

Convert libcommon_em.so into a static library #101

Closed hcneema closed 4 years ago

hcneema commented 6 years ago

We need to do the following

Currently we have SJBRD2:/opt/xilinx/xrt>tree lib lib ├── libcommon_em.so ├── libcpu_em.so ├── libhw_em.so ├── libxilinxopencl.so -> libxilinxopencl.so.2 ├── libxilinxopencl.so.2 -> libxilinxopencl.so.2.1.0 ├── libxilinxopencl.so.2.1.0 ├── libxrtcore.so -> libxrtcore.so.2 ├── libxrtcore.so.2 -> libxrtcore.so.2.1.0 └── libxrtcore.so.2.1.0

  1. Rename libhw_em.so to libxrt_hwem.so
  2. Rename libcpu_em.so to libxrt_swem.so
  3. Remove libcommon_em.so -> create a static library(.a) and embed it within libxrt_swem.so and libxrt_hwem.so
  4. Add .soname versioning.
  5. Remove XILINX_SDX dependency for running the testcase(currently it requires it to be set to any junk value).
  6. Make sure emulation flows work off the changes.
stsoe commented 6 years ago

1),2),4) are done. Mainly 3) remains.

chvamshi-xilinx commented 6 years ago

Hi Soren, I have tried making this change, but it is not working as expected. We are getting "multiple definitions found" error while running a testcase. This error will go away if we use static library of protobuf. Current version of cmake is not supporting it.

stsoe commented 4 years ago

No longer relevant.