XorTroll / uLaunch

:rocket: The themeable Nintendo Switch HOME menu Nintendo forgot to make
https://xortroll.github.io/uLaunch/
GNU General Public License v2.0
618 stars 55 forks source link

New functionality added & more customization options (SFX) + Folder fix + small fixes #203

Closed Simi5599 closed 5 months ago

Simi5599 commented 1 year ago

When pairing a controller from the controller applet an example text was shown. I blanked it and left a comment instead.

Simi5599 commented 1 year ago

I also removed from the README.md the password feature because password functionality was removed in a previous build

Simi5599 commented 1 year ago

With this commit i added new functionalities and customizations to uLaunch, more are planned to be implemented in the next future.

Features added:

This features can be used to create better themes for uLaunch.

We may also need to update the theme wifi in order to reflect changes

XorTroll commented 1 year ago

I haven't checked this all yet, but I'd suggest you to make separate PRs if you are pushing so many different changes ;)

XorTroll commented 1 year ago

Will make this way less messy for both of us

XorTroll commented 1 year ago

I'd also suggest you to discuss these changes/TODOs with me since I may not be willing to add certain stuff or would like to do it in a different way (like via Discord server/DMs)

Simi5599 commented 1 year ago

Ok, we will discuss my TODO in your discord, now i am pushing a bugfix for an SFX issue on the home. Sorry for the long pull request, i am not very familiar with github

Simi5599 commented 1 year ago

Had to put the folder fix in this pr because github does not let me create a new pr

Simi5599 commented 1 year ago

With the last 2 commit i made the folder functionality more reliable, should work perfectly now

Dracrius commented 1 year ago

This and the other PR's should get pulled into master as the project seems to have become stale and lacks development. This isn't surprising with no PR's getting accepted in the last 3 years.

I have started working from Simi5599 last commit as the fixes for folders are needed asap as they are completely useless in the current release! I'd love to add my own PR's but if fixes and improvements need to be pre-approved before we even write them you are just stifling innovation. While I do agree each PR should be a single feature or fix since the project is open source you should be open to things being done a different way then you may have done it.

There is no reason not to accept the docker implementation and the Korean translation for instance. This project is the start of the perfect frontend replacement but if others can not contribute it is dead in the water as a LOT of features are missing.

XorTroll commented 5 months ago

Closing this, but this PR work ended up basing many aspects added to uLaunch (uNew branch) in the last commit, thanks for it ;)