Closed Simi5599 closed 5 months ago
I also removed from the README.md the password feature because password functionality was removed in a previous build
With this commit i added new functionalities and customizations to uLaunch, more are planned to be implemented in the next future.
Features added:
BGM music in the user selection screen
SFX when an user is selected in the user selection screen
SFX when scrolling users in the user selection screen
SFX when scrolling titles in the main menu
SFX when opening the quick menu
SFX when closing the quick menu
SFX when scrolling the quick menu
This features can be used to create better themes for uLaunch.
We may also need to update the theme wifi in order to reflect changes
I haven't checked this all yet, but I'd suggest you to make separate PRs if you are pushing so many different changes ;)
Will make this way less messy for both of us
I'd also suggest you to discuss these changes/TODOs with me since I may not be willing to add certain stuff or would like to do it in a different way (like via Discord server/DMs)
Ok, we will discuss my TODO in your discord, now i am pushing a bugfix for an SFX issue on the home. Sorry for the long pull request, i am not very familiar with github
Had to put the folder fix in this pr because github does not let me create a new pr
With the last 2 commit i made the folder functionality more reliable, should work perfectly now
This and the other PR's should get pulled into master as the project seems to have become stale and lacks development. This isn't surprising with no PR's getting accepted in the last 3 years.
I have started working from Simi5599 last commit as the fixes for folders are needed asap as they are completely useless in the current release! I'd love to add my own PR's but if fixes and improvements need to be pre-approved before we even write them you are just stifling innovation. While I do agree each PR should be a single feature or fix since the project is open source you should be open to things being done a different way then you may have done it.
There is no reason not to accept the docker implementation and the Korean translation for instance. This project is the start of the perfect frontend replacement but if others can not contribute it is dead in the water as a LOT of features are missing.
Closing this, but this PR work ended up basing many aspects added to uLaunch (uNew branch) in the last commit, thanks for it ;)
When pairing a controller from the controller applet an example text was shown. I blanked it and left a comment instead.