search

Xposed-Modules-Repo / ma.wanam.youtubeadaway

YouTube AdAway
95 stars 4 forks source link

can't refresh in home page #7

Open ForestL18 opened 1 year ago

ForestL18 commented 1 year ago

refreshing homepage is not working with the adaway 5.0.3

Orcamm commented 1 year ago

On 5.0.3 refreshing works initially when opening the app but once ad card is removed after refreshing, refreshing no longer works. Also ad card is showing when first opening the app.

wanam commented 1 year ago

Thank you for your report.

Yes, as mentioned here, an ad card is displayed the first time the app is loading because it takes up to 10 seconds to identify the required hook, this is something that needs to be improved for upcoming updates.

Indeed, the second issue about refreshing the main page needs more attention, @killer7Mod any clues about this issue? Could you please share the original source of your changes to see how I can help fix this issue?

megaUwU-ui commented 1 year ago

On 5.0.3 refreshing works initially when opening the app but once ad card is removed after refreshing, refreshing no longer works. Also ad card is showing when first opening the app.

my still work fine, whitelist s.youtube.com in adaway maybe? yt ver: 17.40.41

ForestL18 commented 1 year ago

my yt version:17.49.34

wanam commented 1 year ago

Unfortunately, the only device I'm running xposed on is dead, so I will need some time to setup xposed on another device to reproduce the refresh issue and try to fix it.

wanam commented 1 year ago

After troubleshooting this issue, this bug is related to the patch that sets ads templates as empty component to be removed, I didn't manage yet to identify why this would impact the pull-down to refresh feature.

It seems to be a known issue with this revanced patch https://github.com/revanced/revanced-integrations/pull/129

I will see if there is anything I can do to fix it, or maybe make the ad cards removable optional for the people who prefer to keep the pull down to refresh feature.