Xpra-org / xpra

Persistent remote applications for X11; screen sharing for X11, MacOS and MSWindows.
https://xpra.org/
GNU General Public License v2.0
1.92k stars 165 forks source link

On windows client, change Picture -> Quality will only take effect on GUI after the second clicking #4346

Closed Simba98 closed 3 weeks ago

Simba98 commented 3 weeks ago

Describe the bug On windows client, change Picture -> Quality will only take effect on GUI after the second clicking

To Reproduce

  1. Run Xpra_cmd.exe attach ssh://server
  2. TrayIcon -> Picture -> Quality, by default it should be Auto. Now, click "Best"
  3. Reopen TrayIcon -> Picture -> Quality, you will find it still Auto, now click best again.
  4. Revisit TrayIcon -> Picture -> Quality, now it is "Best"

System Information (please complete the following information):

Additional context Seems like Speed menu also has same issue.

totaam commented 3 weeks ago

Thanks, something must have changed in GTK which made the menu item callbacks trample on each other. The commit above fixes that.