XuezheMax / NeuroNLP2

Deep neural models for core NLP tasks (Pytorch version)
GNU General Public License v3.0
441 stars 89 forks source link

Input file #12

Closed biostanley closed 6 years ago

biostanley commented 6 years ago

XuezheMax, Could you upload the input (train,dev,test) files for run_ner_crf.sh? I read the post on issue#9, and added the word ids accordingly for each sentence from the conll2013 eng.train eng.testa/b dataset. i.e: 18 people NNS I-NP O 19 that IN I-SBAR O 20 I PRP I-NP O 21 grew VBD I-VP O but I got the following two issues: 1) assign_tensor(tensor.data, val) error until maximum recursion depth exceeded:

2) I modified the following line by if not os.path.isdir() to if os.path.isdir() to make use of the new tags out of the ner.json, will this (the folder contains ner.json which limits the tagger format) be ok? original: if not os.path.isdir(alphabet_directory): modify: if os.path.isdir(alphabet_directory): Thank you very much

XuezheMax commented 6 years ago

Hi, Are you using Pytorch 0.4 or o.3? If you use 0.4, please switch to branch 'pytorch4.0' For 2. I did not understand what is your goal. Would you please clarity what you want to do? Thanks.

biostanley commented 6 years ago

Thanks a lot for pointing out the version problem. For 2, I am trying see if the end-to-end framework can be used for other tagging problems, which contains about 15 tags (15 different type of named entities). By modifying the os.path.isdir(alphabet_directory), I want to automatically build a new tag dictionary, any suggestions on what is the best way to do this?
Will the end-to-end framework good for more than 10 tags?

XuezheMax commented 6 years ago

In that way, you just need to prepare your data, remove the folder containing old alphabets, and re-run the code on the new data.

On Sat, Apr 28, 2018 at 8:32 PM, biostanley notifications@github.com wrote:

Thanks a lot for pointing out the version problem. For 2, I am trying see if the end-to-end framework can be used for other tagging problems, which contains about 15 tags. By modifying the os.path.isdir(alphabet_directory), I want to automatically build a new tag dictionary, any suggestions on what is the best way to do this? Will the end-to-end framework good for more than 10 tags?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/XuezheMax/NeuroNLP2/issues/12#issuecomment-385215439, or mute the thread https://github.com/notifications/unsubscribe-auth/ADUtltvKPpdPgz5tXF9PSUWmyX97vICkks5ttQoBgaJpZM4TrT7X .

--

Best regards, Ma,Xuezhe Language Technologies Institute, School of Computer Science, Carnegie Mellon University Tel: +1 206-512-5977