search

Xylopyrographer / STAC

A Roland Smart Tally Atom Client
Other
3 stars 0 forks source link

Mqshaw documentation changes #34

Closed mqshaw closed 3 years ago

mqshaw commented 3 years ago

Hi Rob,

This is the merge request to bring in some documentation changes.

The MPU6886.cpp change is probably due to a different base version that we are using with the underlying library, I think that the change can be ignored by including the header file in addition to the c file, that way we would always ensure that the function declarations match the header.

I responded earlier to your email about my experiences with STAC 1.9 at church tonight.

Best, Mark

Xylopyrographer commented 3 years ago

Mornin’ again:

Thanks Mark. Will merge this into main in a bit.

Cheers, Rob

On May 23, 2021, at 11:20 PM, Mark Shaw @.***> wrote:

Hi Rob,

This is the merge request to bring in some documentation changes.

The MPU6886.cpp change is probably due to a different base version that we are using with the underlying library, I think that the change can be ignored by including the header file in addition to the c file, that way we would always ensure that the function declarations match the header.

I responded earlier to your email about my experiences with STAC 1.9 at church tonight.

Best, Mark

You can view, comment on, or merge this pull request online at:

https://github.com/Xylopyrographer/STAC/pull/34 https://github.com/Xylopyrographer/STAC/pull/34 Commit Summary

Update libraries_README.md Update MyTallyServer Guide.md Update libraries_README.md Update libraries_README.md fixing a bug that was preventing the code from compiling File Changes

M SmartTally Server/MyTallyServer Guide.md https://github.com/Xylopyrographer/STAC/pull/34/files#diff-d0508f620a211071da8f86b8d14a389075359f779a17c8eb77ff6daf821d6968 (2) M libraries/M5Atom/utility/MPU6886.cpp https://github.com/Xylopyrographer/STAC/pull/34/files#diff-fc014ef3d34412f355121fb1b8669a7d765b46fd4af7eb974d5eac82a974429a (30) M libraries/libraries_README.md https://github.com/Xylopyrographer/STAC/pull/34/files#diff-3123ea904c7480dea53ff8702bc7cc510479fe1a283f54999db71780e6eb0021 (21) Patch Links:

https://github.com/Xylopyrographer/STAC/pull/34.patch https://github.com/Xylopyrographer/STAC/pull/34.patch https://github.com/Xylopyrographer/STAC/pull/34.diff https://github.com/Xylopyrographer/STAC/pull/34.diff — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Xylopyrographer/STAC/pull/34, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATMBFQP776OYJ6OCOH5IP53TPHOZRANCNFSM45MQLONA.

Xylopyrographer commented 3 years ago

Thanks Mark!