search

YCAMInterlab / ofxTimeline

lightweight timeline tools for openFrameworks
271 stars 141 forks source link

get current page #103

Closed facultymatt closed 10 years ago

facultymatt commented 10 years ago

There is no getter for currentPage. It would be very useful to add one. Is there another method which works better for getting the current page? This is especially important since tracks will be active even if they are on another page (for example videoTracks), so you need to check for current isCurrentPage along with isSwitchOn().

obviousjim commented 10 years ago

Wow guess not! Should be an easy pull request :)

On Wednesday, April 2, 2014, Matt Miller notifications@github.com wrote:

There is no getter for currentPage. It would be very useful to add one. Is there another method which works better for getting the current page?

— Reply to this email directly or view it on GitHubhttps://github.com/YCAMInterlab/ofxTimeline/issues/103 .

facultymatt commented 10 years ago

Cool, making a PR now. I noticed that isSwitchOn() seems to ignore pages. For example if you have bangs on both pages, the bangs from page 1 will fire even when user is on page 2. Is this the desired behavior? I'm wondering if this happens because we name the triggers the same on both tabs.

facultymatt commented 10 years ago

Also worth noting you can keep track of current page by listening for page change event which is fired like so: ofNotifyEvent(events().pageChanged, pageEvent);

facultymatt commented 10 years ago

See https://github.com/YCAMInterlab/ofxTimeline/pull/104, I added a getter for current page index and name.