search

YHWong20 / pe

0 stars 0 forks source link

NaN problem sets have duplicate IDs #4

Open YHWong20 opened 1 month ago

YHWong20 commented 1 month ago

If 0 is passed as an argument to -n, the problem sets all have ID of 1. This ID is duplicated. Should IDs be uniquely generated?

image.png

nus-pe-script commented 3 weeks ago

Team's Response

All problem sets with 0 problems are considered the same problem set since they are all "empty problem sets", so the ID is not incorrect in this case.

You can make the argument that maybe 0 problems should not be an option, and I would agree. But it's not in scope of this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]