YaLTeR / MouseTweaks

A Minecraft mod that enhances inventory management.
https://minecraft.curseforge.com/projects/mouse-tweaks
BSD 3-Clause "New" or "Revised" License
127 stars 36 forks source link

(Quilt 1.18.2) Possible crash issue with MouseTweaks and fabric/quilt GUI mods? #97

Open PlayfulPiano opened 1 year ago

PlayfulPiano commented 1 year ago

Been having this issue all day today where my game randomly crashes while accessing and interacting with storage inventories (either my own, diamond chests from the mod iron chest, or my storage system from the mod slotlink) without any real mod implication on what's causing the crash.

I asked over in the quilt discord, but I think it might be mousetweaks related. So just in case i'm also reporting in here, too.

Here are my crash logs for reference (4 separate crashes so maybe you can spot something here): https://mclo.gs/1iMFbH2 https://mclo.gs/LYp5NgT https://mclo.gs/UCihgMj https://mclo.gs/2OcxIae

And for the first crash link, here's also the client log link: https://mclo.gs/ZhuOsii

YaLTeR commented 1 year ago

That's weird. Kinda sounds like something is adding multi-threading to code that does not expect it. Well, what Mouse Tweaks does is pretty straight-forward -- it calls slotClicked on AbstractContainerScreens: https://github.com/YaLTeR/MouseTweaks/blob/045d8857b90fd89d76675bfe17fb225b2323a165/src/main/java/yalter/mousetweaks/handlers/GuiContainerHandler.java#L59

Not sure what the issue could be.

PlayfulPiano commented 1 year ago

Huh, wonder what mod might be causing this, if it's even a mod. Literally just started happening to me today with no new mods added. Only had a flush mob farm built in my world which maybe causes lag but I'm not sure how it would cause this.

YaLTeR commented 1 year ago

Only had a flush mob farm built in my world which maybe causes lag but I'm not sure how it would cause this.

Oh yeah I can see something like this start triggering a threading bug... Those are pretty nasty.

PlayfulPiano commented 1 year ago

Do you know what types of mods usually cause threading bugs?

YaLTeR commented 1 year ago

No idea unfortunately