search

Yale-LILY / SummerTime

An open-source text summarization toolkit for non-experts. EMNLP'2021 Demo
https://arxiv.org/abs/2108.12738
Apache License 2.0
264 stars 30 forks source link

troyfeng116/travis-ci #41

Closed troyfeng116 closed 3 years ago

troyfeng116 commented 3 years ago
niansong1996 commented 3 years ago

Great job on this, btw, why does it have two jobs (PR build and branch build)? Aren't they the same thing? Moreover, have you made changes to switch to only one python version?

niansong1996 commented 3 years ago

What's the current status on this, is it ready to be merge?

troyfeng116 commented 3 years ago

What's the current status on this, is it ready to be merge?

Yep, I think it is. However, builds will not be triggered on main (since branch builds are off right now), so unless other open PRs rebase onto main after this one is merged, they could break the build

niansong1996 commented 3 years ago

@troyfeng116 Why do we need openmpi tho?

troyfeng116 commented 3 years ago

@troyfeng116 Why do we need openmpi tho?

I think it was a dependency for an HMNet eval module. Needs to be in requirements.txt, so need a few setup steps for it to be installed on Travis

niansong1996 commented 3 years ago

@troyfeng116 I see that it's currently passing on Travis and the code LGTM. Is it up for merging into main?

troyfeng116 commented 3 years ago

@troyfeng116 I see that it's currently passing on Travis and the code LGTM. Is it up for merging into main?

Yep, we should be good to merge into main. We can look into custom CI servers and cleanup afterwards?

niansong1996 commented 3 years ago

Sounds good to me, merging it now