search

YaroslavGaponov / blackcatmq

STOMP messages broker
BSD 2-Clause "Simplified" License
11 stars 7 forks source link

Support for websockets and stomp v1.1 #5

Closed conartist6 closed 9 years ago

conartist6 commented 9 years ago

The major change in 1.1 that I found lacking was the requirement for clients to generate a subscription id and for the server to include that id in stomp messages.

In order to not affect existing library users I have defaulted the protocol to 1.0 so that the new fields are not required.

I have moved web-callable methods into an object called commands so that the class may have function properties which cannot be accessed over the network. I have created a non-command version of send by which a user of the server may choose to directly message clients.

I have exposed the entire constructor through export as it makes instanceOf checks possible and allows users to extend the class.

conartist6 commented 9 years ago

Oh and I didn't really test it all. It worked for my use case but I don't do everything the library supports and on top of made some extra untested changes when I created the protocols folder and the interface between the broker and the protocols implementations.

Maybe there should be a test framework?