Yashire / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

Div injection #201

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The old version you could pre-place the thumbnail/controller divs etc
so there were where you wanted them to be.

The new version always injects new divs.

old code:
var thumbnails = (el) ? el.empty() : new Element('div', {'class':
this.classes.get('thumbnails').substr(1)}).inject(this.slideshow);

[injects only when creating a new div]

new code:
var el = slideshow.el.getElement(slideshow.classes.get('thumbnails')),
       thumbnails = el ? el.empty() : new Element('div', {'class':
slideshow.classes.get('thumbnails').substr(1)});
...
thumbnails.inject(slideshow.el);

Can we get the inject back on the conditional creation? I think
controller has the same issue, and probably thr other divs as well.

Original issue reported on code.google.com by aeron.gl...@gmail.com on 24 May 2011 at 5:02

GoogleCodeExporter commented 8 years ago
Will be up on github and in the new build later today.

Original comment by aeron.gl...@gmail.com on 9 Jul 2011 at 6:33