Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

Video player subtitles support features #3055

Open jae1911 opened 1 month ago

jae1911 commented 1 month ago

Is your feature request related to a problem? Please describe.

This feature is not related to a problem but some thoughts I had on the video player, related to #2673.

Describe the solution you'd like

Some features that could be nice to have once getting subtitles easily is added:

Having both would ease the use of subtitles substantially.

Describe alternatives you've considered

None.

Additional Context

Requires #2673

Requesters

U-j4 | j4.lc (Discord)

brodokk commented 1 month ago

Something that is not really mentioned in this issue, have the ability to extract and read the subtitle in the video file directly.

The use case I am thinking about would be Movies and TV shows. A bit like VLC is doing while watching this kind of media.

Frooxius commented 1 month ago

My goal for this is to add support for "embedded" subtitles in the video transparently first.

That can either include the subtitles we get from the video itself (assuming UMP has API for that) or ones we extract with yt-dlp and feed those in. We'll add interfaces for feeding in the embedded subtitles to the video player, so they can be displayed.

Frooxius commented 1 month ago

Hmm... I did check the API and as far as I can tell, UMP doesn't really have API to get the subtitle data embedded in the video file, which is a bit unfortunate.

This means we can only support that for YouTube videos and external subtitle files, until we switch the libVLC implementation.