Some color manipulation nodes lose color profile information

Banane9 commented 1 year ago

Some of the color channel manipulation nodes lose color profile information.

Create Multiply and Add nodes for a channel
Create a color input for them and displays for the input and outputs
Observe that the input and output of Multiply have a linear profile, while Add has sRGB

Color profile should be kept regardless of operation

Comparison of Mul, Add and Add HDR

2023.10.18.449

Windows, Linux, Android / Quest

Index

This doesn't appear in the log.

This is an issue in the implementation of the methods on colorX, where the profile isn't passed to the newly created instances.

Banane9 ShadowPanther

shiftyscales commented 8 months ago

Would you mind compiling a list of the nodes this behaviour occurs in, @Banane9?

Otherwise- I've confirmed this issue still occurs.

shiftyscales commented 8 months ago

This also seems like it might be related to #316.

Banane9 commented 8 months ago

colorX Methods I found that discard the color profile:

NormalizeHDR
MulA (MultiplyA has it though, and all other Mul methods are implemented through their Multiply counterparts)
AddR and _HDR
AddG and _HDR
AddB and _HDR
AddA and _HDR
AlphaBlend
AdditiveBlend
SoftAdditiveBlend

shiftyscales commented 8 months ago

Thank you!

Yellow-Dog-Man / Resonite-Issues